Repository navigation
Update EarCut_jll to v3 - #287
Conversation
EarCut_jll v2 was built with an old BinaryBuilder and lists `Pkg` as a dependency; v3.2.3 does not. The C wrapper and its symbols are unchanged (the major bump tracks earcut.hpp catching up with earcut.js v3), but the triangulations differ: earcut 3.2.3 adds a Delaunay refine pass, and triangle and vertex order changed. The expected faces in the tests are updated accordingly; all are still valid triangulations with the same winding. Bump version to 0.5.14. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Gentle bump. |
|
Thanks... I guess this needs to be tagged as breaking though! |
|
Why does it need a breaking release? It changes outputs, but not in a way that breaks any API contracts, right? And thanks for merge! |
|
(since there's 112 direct dependencies, a breaking release seems really scary?) |
|
Well you changed tests, in my book that's the best hint that something is breaking existing tested code.
Well a non breaking release which breaks 112 packages seems scarier to me ;) |
|
But the changed tests here are not really of a breaking sort though: the same exact triangles are returned, only differently sorted (either in face or vertex sorting). For every vertex-reordering, the resulting face has the same normal also (cyclic permutation). |
|
Earcut things the release is breaking 🤷 Well i'm happy to tag it non breaking, once the Makie CI run through with this: |
I think those breaking changes are all about the JS packaging; none of it appears to touch the C++ code which the jll uses afaiu. See Earcut's 3.0.0 changelog. |
🤖 Moves to EarCut_jll v3 (3.2.3, available since JuliaPackaging/Yggdrasil#14434). The current v2 JLL was built with an old BinaryBuilder and pulls in
Pkgas a dependency; v3.2.3 does not, so downstream packages no longer loadPkgthrough GeometryBasics.test/polygons.jlare updated. In all but one test these are exactly the same triangles (same winding), only with faces listed in a different order or vertices rotated within a face. The exception is the square-with-square-hole test, which still gives 8 valid triangles but with different diagonals, due to earcut 3.2.3's new Delaunay refine pass.Pkgdependency drops out for downstream users.